Skip to content

Conversation

@VolodymyrBg
Copy link
Contributor

@VolodymyrBg VolodymyrBg commented Sep 2, 2025

https://portal.thirdweb.com/contracts/modular-contracts/overview - 404
https://portal.thirdweb.com/contracts/modular-contracts - works


PR-Codex overview

This PR updates a link in the page.mdx file related to the modular contract framework, changing the URL to point to a relative path instead of an absolute one.

Detailed summary

  • Updated the link in the Modular Contract section from an absolute URL (https://portal.thirdweb.com/contracts/modular-contracts/overview) to a relative URL (/contracts/modular-contracts).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation
    • Updated a link in the Modular Contract section to point to the internal Modular Contracts page for more reliable navigation.
    • Anchor text unchanged; only destination updated.
    • No functional changes to the app.

Signed-off-by: VolodymyrBg <[email protected]>
@VolodymyrBg VolodymyrBg requested review from a team as code owners September 2, 2025 04:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2025

⚠️ No Changeset found

Latest commit: 96ca736

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Sep 2, 2025

@VolodymyrBg is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 2, 2025

Walkthrough

A single Markdown link in the Modular Contract section was changed: the href was updated from an external URL to an internal relative path; no other content, code, or exported entities were modified.

Changes

Cohort / File(s) Change Summary
Docs link correction
apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx
Replaced one Markdown link target from https://portal.thirdweb.com/contracts/modular-contracts/overview to /contracts/modular-contracts; anchor text unchanged.

Sequence Diagram(s)

No sequence diagram necessary for this documentation-only change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6d76cfe and 96ca736.

📒 Files selected for processing (1)
  • apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Sep 2, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7eed8e6 and 6d76cfe.

📒 Files selected for processing (1)
  • apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx (1 hunks)

### Modular Contract

This contract is created using the modular contract framework. Modules on this contract are upgradeable. [Learn more about Modular Contracts.](https://portal.thirdweb.com/contracts/modular-contracts/overview)
This contract is created using the modular contract framework. Modules on this contract are upgradeable. [Learn more about Modular Contracts.](https://portal.thirdweb.com/contracts/modular-contracts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Good fix: link now targets the live Modular Contracts page

Confirmed the destination resolves. (portal.thirdweb.com)

Optional follow-ups:

  • Prefer a relative href (/contracts/modular-contracts) to avoid hardcoding the domain and to work in preview/staging.
  • Add a docs redirect from /contracts/modular-contracts/overview → /contracts/modular-contracts to prevent future 404s.
  • Quick scan for other occurrences of the old URL:

🏁 Script executed:

#!/bin/bash
# find lingering references to the 404 path
rg -n -S 'portal\.thirdweb\.com/contracts/modular-contracts/overview|/contracts/modular-contracts/overview' -g '!**/node_modules/**'

Length of output: 1893


Replace all /contracts/modular-contracts/overview links with the canonical /contracts/modular-contracts path

  • Update the MDX files under apps/portal/src/app/tokens/explore/pre-built-modular/ (token-drop, edition-drop, nft-collection, nft-drop, edition, open-edition) to use [Learn more about Modular Contracts.](/contracts/modular-contracts)
  • Update the TSX link in apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/contracts/page.tsx
  • Add a redirect from /contracts/modular-contracts/overview/contracts/modular-contracts in the docs routing config to prevent future 404s
🤖 Prompt for AI Agents
In apps/portal/src/app/tokens/explore/pre-built-modular/token/page.mdx around
line 77, replace the existing Learn more link path
/contracts/modular-contracts/overview with the canonical
/contracts/modular-contracts; do the same across the other MDX files in
apps/portal/src/app/tokens/explore/pre-built-modular (token-drop, edition-drop,
nft-collection, nft-drop, edition, open-edition). Also update the TSX link in
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/contracts/page.tsx
to point to /contracts/modular-contracts instead of the /overview path, and add
a redirect rule in the docs routing config (where routes are defined) that maps
/contracts/modular-contracts/overview → /contracts/modular-contracts to prevent
404s.

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.43%. Comparing base (7eed8e6) to head (96ca736).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7962       +/-   ##
===========================================
- Coverage   56.52%   36.43%   -20.10%     
===========================================
  Files         904      897        -7     
  Lines       58623    58126      -497     
  Branches     4146     2328     -1818     
===========================================
- Hits        33138    21179    -11959     
- Misses      25380    36874    +11494     
+ Partials      105       73       -32     
Flag Coverage Δ
packages 36.43% <ø> (-20.10%) ⬇️
see 299 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 5b871ac into thirdweb-dev:main Sep 2, 2025
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants